cloud-fan commented on code in PR #44093:
URL: https://github.com/apache/spark/pull/44093#discussion_r1425026420
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala:
##########
@@ -903,4 +905,68 @@ class SparkSqlAstBuilder extends AstBuilder {
(ctx.LOCAL != null, finalStorage, Some(DDLUtils.HIVE_PROVIDER))
}
+
+ /**
+ * Returns the parameters for [[ExecuteImmediateQuery]] logical plan.
+ * Expected format:
+ * {{{
+ * EXECUTE IMMEDIATE {query_string|string_literal}
+ * [INTO target1, target2] [USING param1, param2, ...]
+ * }}}
+ */
+ override def visitExecuteImmediate(ctx: ExecuteImmediateContext):
LogicalPlan = withOrigin(ctx) {
Review Comment:
the general principle is, if the parsed plan is in `ExecuteImmediateQuery`,
the parser code should be in `AstBuilder` instead of `SparkSqlAstBuilder`
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala:
##########
@@ -903,4 +905,68 @@ class SparkSqlAstBuilder extends AstBuilder {
(ctx.LOCAL != null, finalStorage, Some(DDLUtils.HIVE_PROVIDER))
}
+
+ /**
+ * Returns the parameters for [[ExecuteImmediateQuery]] logical plan.
+ * Expected format:
+ * {{{
+ * EXECUTE IMMEDIATE {query_string|string_literal}
+ * [INTO target1, target2] [USING param1, param2, ...]
+ * }}}
+ */
+ override def visitExecuteImmediate(ctx: ExecuteImmediateContext):
LogicalPlan = withOrigin(ctx) {
Review Comment:
the general principle is, if the parsed plan is in catalyst, the parser code
should be in `AstBuilder` instead of `SparkSqlAstBuilder`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
