milastdbx commented on code in PR #44093:
URL: https://github.com/apache/spark/pull/44093#discussion_r1425079513
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -557,7 +557,13 @@ class AstBuilder extends DataTypeAstBuilder with
SQLConfHelper with Logging {
notMatchedBySourceActions.toSeq)
}
- /**
+ override def visitMultipartIdentifierList(
+ ctx: MultipartIdentifierListContext): Seq[UnresolvedAttribute] =
withOrigin(ctx) {
Review Comment:
in USING we can either have literal or variable, and we need to distinguish
between these two in SubstituteExecuteImmediate rule, hence i think its cleaner
to have AST node than to pass Seq[String] directly and also I wouldn't be able
to apply pattern matching
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
