dtenedor commented on code in PR #44261:
URL: https://github.com/apache/spark/pull/44261#discussion_r1427197722
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveInlineTables.scala:
##########
@@ -33,12 +34,14 @@ import org.apache.spark.sql.types.{StructField, StructType}
*/
object ResolveInlineTables extends Rule[LogicalPlan]
with CastSupport with AliasHelper with EvalHelper {
- override def apply(plan: LogicalPlan): LogicalPlan =
plan.resolveOperatorsWithPruning(
- AlwaysProcess.fn, ruleId) {
- case table: UnresolvedInlineTable if table.expressionsResolved =>
- validateInputDimension(table)
- validateInputEvaluable(table)
- convert(table)
+ override def apply(plan: LogicalPlan): LogicalPlan = {
+ plan.resolveOperatorsDown(p =>
ComputeCurrentTime(p)).resolveOperatorsWithPruning(
Review Comment:
why do we need to change `ResolveInlineTables` in this way in this PR?
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala:
##########
@@ -79,30 +79,22 @@ class DateExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
}
test("datetime function current_date") {
- val d0 = DateTimeUtils.currentDate(UTC)
- val cd = CurrentDate(UTC_OPT).eval(EmptyRow).asInstanceOf[Int]
- val d1 = DateTimeUtils.currentDate(UTC)
- assert(d0 <= cd && cd <= d1 && d1 - d0 <= 1)
+ assert(intercept[SparkException] {
+ CurrentDate(UTC_OPT).eval(EmptyRow)
+ }.getMessage.contains("Cannot evaluate expression"))
Review Comment:
instead of asserting that the error message contains substrings, could you
use `checkError` to compare the expected error class against the actual one?
Here's an example:
https://github.com/apache/spark/blob/c045a425bf0c472f164e3ef75a8a2c68d72d61d3/sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/AlterTableAddPartitionSuite.scala#L42-L51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
