cloud-fan commented on code in PR #44261:
URL: https://github.com/apache/spark/pull/44261#discussion_r1437460354
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala:
##########
@@ -79,30 +79,22 @@ class DateExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
}
test("datetime function current_date") {
Review Comment:
Actually these tests were not useful at all previously, as they are testing
dead code. We should check `ComputeCurrentTimeSuite` and make sure it has good
test coverage for the execution part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
