MaxGekk commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1431044474
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -1180,12 +1180,15 @@ object JdbcUtils extends Logging with SQLConfHelper {
}
}
- def classifyException[T](message: String, dialect: JdbcDialect)(f: => T): T
= {
+ def classifyException[T](
Review Comment:
> So if a dialect can classify an exception, we will lose the error class
which is actually worse?
@cloud-fan A dialect can override proposed error class and make our default
error class more precise using the driver specific info. And yes, the original
error class will be lost.
> Can we also enable MiMa for this? I believe this is being skipped because
it's under execution package.
@HyukjinKwon I made the modification because MiMa complained. Did you change
MiMa to expect different behaviour?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
