cloud-fan commented on code in PR #44358:
URL: https://github.com/apache/spark/pull/44358#discussion_r1431056358
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -1180,12 +1180,15 @@ object JdbcUtils extends Logging with SQLConfHelper {
}
}
- def classifyException[T](message: String, dialect: JdbcDialect)(f: => T): T
= {
+ def classifyException[T](
Review Comment:
I think losing the original error class is bad. We added `classifyException`
for getting more precise java exception type, but I don't think this is useful
anymore as we have error classes. My suggestion is to deprecate
`classifyException`, saying that Spark never calls it anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
