dongjoon-hyun commented on code in PR #44428:
URL: https://github.com/apache/spark/pull/44428#discussion_r1433277753
##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetVectorUpdaterFactory.java:
##########
@@ -195,12 +203,11 @@ boolean
isTimestampTypeMatched(LogicalTypeAnnotation.TimeUnit unit) {
annotation.getUnit() == unit;
}
- void validateTimestampType(DataType sparkType) {
+ void validateTimestampNTZType(DataType sparkType) {
assert(logicalTypeAnnotation instanceof TimestampLogicalTypeAnnotation);
- // Throw an exception if the Parquet type is TimestampLTZ and the Catalyst
type is TimestampNTZ.
+ // Throw an exception if the Parquet type is TimestampLTZ as the Catalyst
type is TimestampNTZ.
Review Comment:
This looks like a wrong change. Could you double-check?
##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetVectorUpdaterFactory.java:
##########
@@ -195,12 +203,11 @@ boolean
isTimestampTypeMatched(LogicalTypeAnnotation.TimeUnit unit) {
annotation.getUnit() == unit;
}
- void validateTimestampType(DataType sparkType) {
+ void validateTimestampNTZType(DataType sparkType) {
assert(logicalTypeAnnotation instanceof TimestampLogicalTypeAnnotation);
- // Throw an exception if the Parquet type is TimestampLTZ and the Catalyst
type is TimestampNTZ.
+ // Throw an exception if the Parquet type is TimestampLTZ as the Catalyst
type is TimestampNTZ.
Review Comment:
This looks like a wrong change. Could you double-check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
