LuciferYang commented on code in PR #44428:
URL: https://github.com/apache/spark/pull/44428#discussion_r1433622489
##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetVectorUpdaterFactory.java:
##########
@@ -195,12 +203,11 @@ boolean
isTimestampTypeMatched(LogicalTypeAnnotation.TimeUnit unit) {
annotation.getUnit() == unit;
}
- void validateTimestampType(DataType sparkType) {
+ void validateTimestampNTZType(DataType sparkType) {
Review Comment:
1. The input parameter `sparkType` is no longer in use, can it be removed?
2. Although the old code is like this, in non-ea mode, `assert` is invalid.
3. Is it possible to reduce the access scope of the
`validateTimestampNTZType` method to `private` in this pr? It does not need to
be accessed by other classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
