heyihong commented on code in PR #44468:
URL: https://github.com/apache/spark/pull/44468#discussion_r1437557546
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala:
##########
@@ -85,7 +85,13 @@ class ClientE2ETestSuite extends RemoteSparkSession with
SQLHelper with PrivateM
|""".stripMargin)
.collect()
}
- assert(ex.getErrorClass != null)
+ assert(
+ ex.getErrorClass ===
+ "INCONSISTENT_BEHAVIOR_CROSS_VERSION.PARSE_DATETIME_BY_NEW_PARSER")
+ assert(
+ ex.getMessageParameters.asScala == Map(
Review Comment:
This is not always true, `getMessageParameters()` only returned empty Map
when error enrichment is disabled or doesn't work
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala:
##########
@@ -85,7 +85,13 @@ class ClientE2ETestSuite extends RemoteSparkSession with
SQLHelper with PrivateM
|""".stripMargin)
.collect()
}
- assert(ex.getErrorClass != null)
+ assert(
+ ex.getErrorClass ===
+ "INCONSISTENT_BEHAVIOR_CROSS_VERSION.PARSE_DATETIME_BY_NEW_PARSER")
+ assert(
+ ex.getMessageParameters.asScala == Map(
Review Comment:
This is partially true, `getMessageParameters()` only returned empty Map
when error enrichment is disabled or doesn't work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
