heyihong commented on code in PR #44468:
URL: https://github.com/apache/spark/pull/44468#discussion_r1437558634
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/utils/ErrorUtils.scala:
##########
@@ -181,7 +182,12 @@ private[connect] object ErrorUtils extends Logging {
}
val errorClass = e.getErrorClass
if (errorClass != null && errorClass.nonEmpty) {
- errorInfo.putMetadata("errorClass", errorClass)
+ val messageParameters = JsonMethods.compact(
+
JsonMethods.render(map2jvalue(e.getMessageParameters.asScala.toMap)))
+ if (messageParameters.length <= maxMetadataSize) {
+ errorInfo.putMetadata("errorClass", errorClass)
+ errorInfo.putMetadata("messageParameters", messageParameters)
Review Comment:
Constructing exceptions based on error class and message parameters only
works well for Scala client if I understand correctly? For Python client, it
only recognizes a very limited set of error classes.
https://github.com/databricks/runtime/blob/master/python/pyspark/errors/error_classes.py#L1114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
