cloud-fan commented on code in PR #44538:
URL: https://github.com/apache/spark/pull/44538#discussion_r1442793883
##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala:
##########
@@ -2125,6 +2126,35 @@ class DataFrameAggregateSuite extends QueryTest
Seq(Row(1))
)
}
+
+ test("SPARK-46536 Support GROUP BY CalendarIntervalType") {
+ val numRows = 50
+ val configurations = Seq(
+ Seq.empty[(String, String)], // hash aggregate is used by default
Review Comment:
We also need to set `spark.sql.TungstenAggregate.testFallbackStartsAt`, see
the code in
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala#L81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
