stefankandic commented on code in PR #44538:
URL: https://github.com/apache/spark/pull/44538#discussion_r1441762796
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala:
##########
@@ -77,9 +77,12 @@ object AggUtils {
child: SparkPlan): SparkPlan = {
val useHash = Aggregate.supportsHashAggregate(
aggregateExpressions.flatMap(_.aggregateFunction.aggBufferAttributes))
+
+ val forceHashAggregate = forceApplyHashAggregate(child.conf)
Review Comment:
I did it because I like that this way it is immediately obvious in the test
case what the config is saying instead of relying on a default which could
technically change at any time.
However if you disagree I'm not against removing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
