HeartSaVioR commented on code in PR #44542:
URL: https://github.com/apache/spark/pull/44542#discussion_r1445805415
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala:
##########
@@ -84,10 +84,11 @@ trait ReadStateStore {
/**
* Clean up the resource.
- *
+ * @param releaseOnly - if true, only release the instance lock and do not
run the full abort
+ * sequence.
* The method name is to respect backward compatibility on [[StateStore]].
*/
- def abort(): Unit
+ def abort(releaseOnly: Boolean = false): Unit
Review Comment:
This is technically a breaking API change. Also, releasing instance lock is
very specific to RocksDB state store provider implementation, which breaks
abstraction. It should be probably the last resort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
