HeartSaVioR commented on code in PR #44542:
URL: https://github.com/apache/spark/pull/44542#discussion_r1446779347
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -452,6 +452,7 @@ class RocksDB(
* Drop uncommitted changes, and roll back to previous version.
*/
def rollback(): Unit = {
+ acquire()
Review Comment:
nit: This is now a side-effect change. Do we want to keep this or just
remove this? I feel like it's safer to add acquire() here, but once you update
the PR title and description to reflect the new direction, this change is
beyond the scope.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala:
##########
Review Comment:
nit: revert the change, previous indentation seems to be right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
