yaooqinn commented on code in PR #44575:
URL: https://github.com/apache/spark/pull/44575#discussion_r1446013353
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala:
##########
@@ -201,6 +201,16 @@ private[spark] object HiveUtils extends Logging {
.booleanConf
.createWithDefault(true)
+ val HIVE_THRIFT_SERVER_EXIT_ON_ERROR =
+ buildConf("spark.sql.hive.thriftServer.exitOnThriftCLIServiceError")
+ .internal()
+ .doc("When true, System.exit(-1) will be called if the underlying
TServer/HTTPServer " +
+ "encounters an error when start serving. When false, the error will be
thrown which" +
+ "enables error handling of the DeveloperApi
`HiveThriftServer2.startWithContext`")
+ .version("4.0.0")
+ .booleanConf
+ .createWithDefault(true)
Review Comment:
> Will anyone set this config in production?
This question is difficult to answer. But, it can be used in production when
using `startWithContext` together.
> It looks fishy to me to add a new config to fix flaky tests.
Or, we can have another try to modify `startWithContext` directly to add a
new bool parameter that works as same as the new config. But because the spark
thrift-server is initialized by HiveConf instance, we still need a new key to
store this bool value in order to pass it into the ThriftCLIService. Otherwise,
we might need extra work to refactor the thrift-server bootstraping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
