yaooqinn commented on code in PR #44575:
URL: https://github.com/apache/spark/pull/44575#discussion_r1448211675
##########
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SharedThriftServer.scala:
##########
@@ -138,10 +138,15 @@ trait SharedThriftServer extends SharedSparkSession {
sqlContext.setConf(ConfVars.HIVE_START_CLEANUP_SCRATCHDIR.varname, "true")
try {
- hiveServer2 = HiveThriftServer2.startWithContext(sqlContext)
+ hiveServer2 = HiveThriftServer2.startWithContext(sqlContext, exitOnError
= false)
Review Comment:
OK. Please check whether the comments added are informative or not.
##########
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SharedThriftServer.scala:
##########
@@ -138,10 +138,15 @@ trait SharedThriftServer extends SharedSparkSession {
sqlContext.setConf(ConfVars.HIVE_START_CLEANUP_SCRATCHDIR.varname, "true")
try {
- hiveServer2 = HiveThriftServer2.startWithContext(sqlContext)
+ hiveServer2 = HiveThriftServer2.startWithContext(sqlContext, exitOnError
= false)
hiveServer2.getServices.asScala.foreach {
case t: ThriftCLIService =>
serverPort = t.getPortNumber
+ if (t.isInstanceOf[ThriftBinaryCLIService] && mode ==
ServerMode.http) {
+ logError("A previous Hive's SessionState is leaked, aborting this
retry")
+ throw new IllegalStateException("HiveThriftServer2 started in
binary mode " +
Review Comment:
addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
