kelvinjian-db commented on code in PR #44716: URL: https://github.com/apache/spark/pull/44716#discussion_r1454048236
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala: ########## @@ -2983,6 +2983,9 @@ case class Sequence( override def nullable: Boolean = children.exists(_.nullable) + // If step is defined, then an error will be thrown if the start and stop do not satisfy the step. + override lazy val throwable: Boolean = stepOpt.isDefined Review Comment: the problem with `NoThrow` is that it doesn't mark that many expressions right now (i.e. if we only push down `NoThrow` expressions then we would be not pushing down most things). we want the opposite here (marking only certain expressions not to push down). defining it this way also allows us to be more precise with defining what is throwable, compared to just setting it for the class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
