cloud-fan commented on code in PR #44716: URL: https://github.com/apache/spark/pull/44716#discussion_r1455258986
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala: ########## @@ -2983,6 +2983,9 @@ case class Sequence( override def nullable: Boolean = children.exists(_.nullable) + // If step is defined, then an error will be thrown if the start and stop do not satisfy the step. + override lazy val throwable: Boolean = stepOpt.isDefined Review Comment: Because it's indeed an expression property. `NoThrow` is not the right way to add properties as the caller side needs to do recursion: https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala#L53-L59 , which is not good for code reuse (you need to call a util function) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
