nchammas commented on code in PR #44756: URL: https://github.com/apache/spark/pull/44756#discussion_r1455840556
########## docs/util/config-groups.yaml: ########## @@ -0,0 +1,50 @@ +# HTML tables will be generated for each of the config groups defined here. +# +# NOTE: +# [email protected] will silently overwrite the value of a key if it is defined +# multiple times. Be sure not to accidentally define a group more than once. +# See: https://github.com/yaml/pyyaml/issues/165 +sql-tuning-caching-data: + - spark.sql.inMemoryColumnarStorage.compressed + - spark.sql.inMemoryColumnarStorage.batchSize +sql-tuning-broadcast: + - spark.sql.autoBroadcastJoinThreshold + - spark.sql.broadcastTimeout Review Comment: Configs can be assigned to multiple groups if they need to be displayed multiple times across our documentation. The groups I have currently defined in this file correspond to the config tables currently in [docs/sql-performance-tuning.md][1], but they can be changed as desired. So `spark.sql.adaptive.autoBroadcastJoinThreshold`, for example, can be assigned both to the `sql-tuning-broadcast` group as well as the `sql-tuning-aqe-broadcast-join` group. And it will be displayed in both of the corresponding config tables that are generated. Does that address your concern? [1]: https://github.com/apache/spark/blob/977f64f0904e46e72cbe5b2252f2657dde29c90c/docs/sql-performance-tuning.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
