Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6405#discussion_r31195896
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -17,72 +17,87 @@
package org.apache.spark.sql.catalyst.expressions
-import org.apache.spark.sql.catalyst.analysis.UnresolvedException
-import org.apache.spark.sql.catalyst.errors.TreeNodeException
+import org.apache.spark.sql.catalyst.util.TypeUtils
import org.apache.spark.sql.types._
-case class UnaryMinus(child: Expression) extends UnaryExpression {
-
- override def dataType: DataType = child.dataType
- override def foldable: Boolean = child.foldable
- override def nullable: Boolean = child.nullable
- override def toString: String = s"-$child"
-
- lazy val numeric = dataType match {
- case n: NumericType => n.numeric.asInstanceOf[Numeric[Any]]
- case other => sys.error(s"Type $other does not support numeric
operations")
- }
+abstract class UnaryArithmetic extends UnaryExpression {
+ self: Product =>
override def eval(input: Row): Any = {
val evalE = child.eval(input)
if (evalE == null) {
null
} else {
- numeric.negate(evalE)
+ evalInternal(evalE)
}
}
+
+ protected def evalInternal(evalE: Any): Any =
+ sys.error(s"UnaryArithmetics must either override eval or
evalInternal")
}
-case class Sqrt(child: Expression) extends UnaryExpression {
+case class UnaryMinus(child: Expression) extends UnaryArithmetic {
+ override def dataType: DataType = child.dataType
+ override def toString: String = s"-$child"
+
+ override def typeMismatchErrorMessage: Option[String] = {
--- End diff --
we can push all typeMismatchErrorMessage for UnaryArithmetic into
UnaryArithmetic?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
