Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6405#discussion_r31199589
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -125,7 +133,9 @@ case class GroupExpression(children: Seq[Expression])
extends Expression {
* so that the proper type conversions can be performed in the analyzer.
*/
trait ExpectsInputTypes {
+ self: Expression =>
def expectedChildTypes: Seq[DataType]
+ override def validInputTypes: Boolean = children.map(_.dataType) ==
expectedChildTypes
--- End diff --
Actually I don't like the handling of `ExpectsInputTypes`: we do type
casting anyway, then if something is wrong, error will be reported for `Cast`,
not the root cause -- wrong input types for a expression.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
