dongjoon-hyun commented on code in PR #44888:
URL: https://github.com/apache/spark/pull/44888#discussion_r1467174600
##########
core/src/main/scala/org/apache/spark/deploy/worker/ui/LogPage.scala:
##########
@@ -137,8 +143,16 @@ private[ui] class LogPage(parent: WorkerWebUI) extends
WebUIPage("logPage") with
return ("Error: invalid log directory " + logDirectory, 0, 0, 0)
}
+ // Find a log file name
+ val fileName = if (logType.equals("out")) {
+ normalizedLogDir.listFiles.map(_.getName).filter(_.endsWith(".out"))
+ .headOption.getOrElse(logType)
Review Comment:
Ya, that's a possible configuration, but this PR is supposed to be used with
an explicitly user-given `SPARK_LOG_DIR`, @yaooqinn . In addition, in these
day, Spark Standalone cluster is running on top of K8s environment. I believe
we can clarify the assumption during documentation, @yaooqinn .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
