yaooqinn commented on code in PR #44888:
URL: https://github.com/apache/spark/pull/44888#discussion_r1467182297


##########
core/src/main/scala/org/apache/spark/deploy/worker/ui/LogPage.scala:
##########
@@ -137,8 +143,16 @@ private[ui] class LogPage(parent: WorkerWebUI) extends 
WebUIPage("logPage") with
       return ("Error: invalid log directory " + logDirectory, 0, 0, 0)
     }
 
+    // Find a log file name
+    val fileName = if (logType.equals("out")) {
+      normalizedLogDir.listFiles.map(_.getName).filter(_.endsWith(".out"))
+        .headOption.getOrElse(logType)

Review Comment:
   > - `SPARK_WORKER_INSTANCES` is deprecated in Standalone mode. It's 
recommended to launch multiple executors in one worker and launch one worker 
per node instead of launching multiple workers per node and launching one 
executor per worker.
   
   I found this statement. I agree w/ you that we doc this. @dongjoon-hyun 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to