HyukjinKwon commented on code in PR #44778:
URL: https://github.com/apache/spark/pull/44778#discussion_r1469111861


##########
python/pyspark/sql/tests/test_udf.py:
##########
@@ -1039,13 +1045,15 @@ def test_udf(a):
         with self.assertRaisesRegex(PythonException, "StopIteration"):
             self.spark.range(10).select(test_udf(col("id"))).show()
 
+    @unittest.skipIf(not have_pyarrow, pyarrow_requirement_message)
     def test_python_udf_segfault(self):
         with 
self.sql_conf({"spark.sql.execution.pyspark.udf.faulthandler.enabled": True}):
             with self.assertRaisesRegex(Exception, "Segmentation fault"):
                 import ctypes
 
                 self.spark.range(1).select(udf(lambda x: 
ctypes.string_at(0))("id")).collect()

Review Comment:
   Why does this need Arrow?



##########
python/pyspark/sql/tests/test_udf.py:
##########
@@ -1039,13 +1045,15 @@ def test_udf(a):
         with self.assertRaisesRegex(PythonException, "StopIteration"):
             self.spark.range(10).select(test_udf(col("id"))).show()
 
+    @unittest.skipIf(not have_pyarrow, pyarrow_requirement_message)
     def test_python_udf_segfault(self):
         with 
self.sql_conf({"spark.sql.execution.pyspark.udf.faulthandler.enabled": True}):
             with self.assertRaisesRegex(Exception, "Segmentation fault"):
                 import ctypes
 
                 self.spark.range(1).select(udf(lambda x: 
ctypes.string_at(0))("id")).collect()

Review Comment:
   Mind sharing test failure message



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to