panbingkun commented on code in PR #44778: URL: https://github.com/apache/spark/pull/44778#discussion_r1469235826
########## python/pyspark/testing/connectutils.py: ########## @@ -89,7 +89,8 @@ def __getattr__(self, item): @unittest.skipIf(not should_test_connect, connect_requirement_message) class PlanOnlyTestFixture(unittest.TestCase, PySparkErrorTestUtils): - from pyspark.sql.connect.dataframe import DataFrame + if should_test_connect: + from pyspark.sql.connect.dataframe import DataFrame Review Comment: https://github.com/panbingkun/spark/actions/runs/7692459974/job/20959442644#step:12:3887 <img width="1002" alt="image" src="https://github.com/apache/spark/assets/15246973/c3b1aa88-1942-4ffa-a9a1-f53ce34a8979";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
