srowen commented on code in PR #44951:
URL: https://github.com/apache/spark/pull/44951#discussion_r1471325443
##########
core/src/main/scala/org/apache/spark/executor/ExecutorExitCode.scala:
##########
@@ -47,9 +47,9 @@ object ExecutorExitCode {
def explainExitCode(exitCode: Int): String = {
exitCode match {
- case UNCAUGHT_EXCEPTION => "Uncaught exception"
- case UNCAUGHT_EXCEPTION_TWICE => "Uncaught exception, and logging the
exception failed"
- case OOM => "OutOfMemoryError"
+ case UNCAUGHT_EXCEPTION => "Uncaught exception."
+ case UNCAUGHT_EXCEPTION_TWICE => "Uncaught exception, and logging the
exception failed."
+ case OOM => "OutOfMemoryError."
Review Comment:
Total nit but do we need these changes? they're not sentences.
Otherwise fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]