pan3793 commented on code in PR #44951:
URL: https://github.com/apache/spark/pull/44951#discussion_r1478089597
##########
core/src/main/scala/org/apache/spark/executor/ExecutorExitCode.scala:
##########
@@ -47,8 +47,8 @@ object ExecutorExitCode {
def explainExitCode(exitCode: Int): String = {
exitCode match {
- case UNCAUGHT_EXCEPTION => "Uncaught exception"
- case UNCAUGHT_EXCEPTION_TWICE => "Uncaught exception, and logging the
exception failed"
+ case UNCAUGHT_EXCEPTION => "Uncaught exception."
+ case UNCAUGHT_EXCEPTION_TWICE => "Uncaught exception, and logging the
exception failed."
Review Comment:
Emm... So you mean we should remove all tailing dots in this function, and
do appending on the caller side if necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
