srowen commented on code in PR #44718:
URL: https://github.com/apache/spark/pull/44718#discussion_r1478107179
##########
core/src/main/scala/org/apache/spark/BarrierTaskContext.scala:
##########
@@ -283,6 +284,7 @@ object BarrierTaskContext {
@Since("2.4.0")
def get(): BarrierTaskContext =
TaskContext.get().asInstanceOf[BarrierTaskContext]
- private val timer = new Timer("Barrier task timer for barrier() calls.")
+ private val timer = ThreadUtils.newSingleThreadScheduledExecutor(
Review Comment:
Hm I guess there is no place to shut this down. It's not critical and not
something we have to change here. I wonder if it should be a daemon thread
though? seems weird to spawn a thread that nothing in the code can terminate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
