srowen commented on code in PR #44718:
URL: https://github.com/apache/spark/pull/44718#discussion_r1478158231
##########
core/src/main/scala/org/apache/spark/BarrierTaskContext.scala:
##########
@@ -283,6 +284,7 @@ object BarrierTaskContext {
@Since("2.4.0")
def get(): BarrierTaskContext =
TaskContext.get().asInstanceOf[BarrierTaskContext]
- private val timer = new Timer("Barrier task timer for barrier() calls.")
+ private val timer = ThreadUtils.newSingleThreadScheduledExecutor(
Review Comment:
That doesn't shut down the executor though, and the other code paths do. I
don't see how the non-daemon thread ever terminates. It may not matter as the
Spark context lives as long as the app. It'd be tidy to shut it down, or make
it a daemon anyway, but not strictly related to the change you're making
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
