cloud-fan commented on code in PR #45064:
URL: https://github.com/apache/spark/pull/45064#discussion_r1482890623
##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -1410,6 +1422,13 @@ public boolean equals(final Object other) {
}
}
+ /**
+ * Collation-aware equality comparison of two UTF8String.
+ */
+ public boolean semanticEquals(final UTF8String other, int collationId) {
+ return
CollationFactory.fetchCollation(collationId).equalsFunction.apply(this, other);
Review Comment:
I'm a bit worried about perf issues here. This is invoked per-row. How much
is the overhead here if the collation id is actually `UCS_BASIC`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
