LuciferYang opened a new pull request, #45141:
URL: https://github.com/apache/spark/pull/45141
### What changes were proposed in this pull request?
This PR add a new function `normalizeDataframeId` to sets the `dataframeId`
to the constant 0 of `CollectMetrics` before comparing `LogicalPlan` in the
test case of `SparkConnectProtoSuite`.
### Why are the changes needed?
The test scenario in `SparkConnectProtoSuite` does not need to compare the
`dataframeId` in `CollectMetrics`
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
- Manually check
run
```
build/mvn clean install -pl connector/connect/server -am -DskipTests
build/mvn test -pl connector/connect/server
```
**Before**
```
- Test observe *** FAILED ***
== FAIL: Plans do not match ===
!CollectMetrics my_metric, [min(id#0) AS min_val#0, max(id#0) AS
max_val#0, sum(id#0) AS sum(id)#0L], 0 CollectMetrics my_metric, [min(id#0)
AS min_val#0, max(id#0) AS max_val#0, sum(id#0) AS sum(id)#0L], 53
+- LocalRelation <empty>, [id#0, name#0]
+- LocalRelation <empty>, [id#0, name#0]
(PlanTest.scala:179)
```
**After**
```
Run completed in 41 seconds, 631 milliseconds.
Total number of tests run: 882
Suites: completed 24, aborted 0
Tests: succeeded 882, failed 0, canceled 0, ignored 0, pending 0
All tests passed.
```
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
