cloud-fan commented on code in PR #45102:
URL: https://github.com/apache/spark/pull/45102#discussion_r1494684198
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcSQLQueryBuilder.scala:
##########
@@ -81,17 +81,21 @@ class JdbcSQLQueryBuilder(dialect: JdbcDialect, options:
JDBCOptions) {
/**
* Constructs the WHERE clause that following dialect's SQL syntax.
*/
- def withPredicates(predicates: Array[Predicate], part: JDBCPartition):
JdbcSQLQueryBuilder = {
+ def withPredicates(
+ predicates: Array[Predicate],
+ part: Option[JDBCPartition]): JdbcSQLQueryBuilder = {
Review Comment:
This is a public API and we can't change its signature. How about we pass a
fake `JDBCPartition` in EXPLAIN?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
