urosstan-db commented on code in PR #45102:
URL: https://github.com/apache/spark/pull/45102#discussion_r1494692948
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcSQLQueryBuilder.scala:
##########
@@ -81,17 +81,21 @@ class JdbcSQLQueryBuilder(dialect: JdbcDialect, options:
JDBCOptions) {
/**
* Constructs the WHERE clause that following dialect's SQL syntax.
*/
- def withPredicates(predicates: Array[Predicate], part: JDBCPartition):
JdbcSQLQueryBuilder = {
+ def withPredicates(
+ predicates: Array[Predicate],
+ part: Option[JDBCPartition]): JdbcSQLQueryBuilder = {
Review Comment:
We can do that, we can pass JDBCPartition(whereClause = null, idx = 0).
Or maybe, we can skip withPredicates method from generateJDBCQuery (maybe a
little bit nicer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
