itholic commented on code in PR #44881: URL: https://github.com/apache/spark/pull/44881#discussion_r1495302902
########## python/pyspark/pandas/series.py: ########## @@ -7092,15 +7092,15 @@ def resample( ---------- rule : str The offset string or object representing target conversion. - Currently, supported units are {'Y', 'A', 'M', 'D', 'H', - 'T', 'MIN', 'S'}. + Currently, supported units are {'YE', 'A', 'ME', 'D', 'h', + 'min', 'MIN', 's'}. Review Comment: Yeah, Pandas 2.2.0 brings couple of breaking changes so we should make sure we ship this support after Spark 4.0.0. See [related update from Pandas release note](https://pandas.pydata.org/docs/whatsnew/v2.2.0.html#deprecate-aliases-m-q-y-etc-in-favour-of-me-qe-ye-etc-for-offsets) for more detail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org