itholic commented on code in PR #44881:
URL: https://github.com/apache/spark/pull/44881#discussion_r1495320737
##########
python/pyspark/pandas/series.py:
##########
@@ -7092,15 +7092,15 @@ def resample(
----------
rule : str
The offset string or object representing target conversion.
- Currently, supported units are {'Y', 'A', 'M', 'D', 'H',
- 'T', 'MIN', 'S'}.
+ Currently, supported units are {'YE', 'A', 'ME', 'D', 'h',
+ 'min', 'MIN', 's'}.
Review Comment:
Oh, sorry that was my mistake. This should work even in old Pandas before
Spark 4.0.0 release.
Let me fix them to work both Pandas 2.2.0 and old Pandas.
##########
python/pyspark/pandas/series.py:
##########
@@ -7092,15 +7092,15 @@ def resample(
----------
rule : str
The offset string or object representing target conversion.
- Currently, supported units are {'Y', 'A', 'M', 'D', 'H',
- 'T', 'MIN', 'S'}.
+ Currently, supported units are {'YE', 'A', 'ME', 'D', 'h',
+ 'min', 'MIN', 's'}.
Review Comment:
~~However, the current rule is that it should not be accompanied by such a
breaking change unless the major version changes.~~
~~This means that users should be able to use their pipeline as is, as long
as they are using at least version 3.x of Spark.~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
