HiuKwok commented on code in PR #45154:
URL: https://github.com/apache/spark/pull/45154#discussion_r1495317771


##########
project/MimaExcludes.scala:
##########
@@ -79,7 +79,10 @@ object MimaExcludes {
     // TODO(SPARK-46878): Invalid Mima report for StringType extension
     
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.types.StringType.this"),
     // SPARK-47011: Remove deprecated 
BinaryClassificationMetrics.scoreLabelsWeight
-    
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.mllib.evaluation.BinaryClassificationMetrics.scoreLabelsWeight")
+    
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.mllib.evaluation.BinaryClassificationMetrics.scoreLabelsWeight"),
+    // SPARK-46938: Javax -> Jakrata namespace change.
+    
ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.ui.ProxyRedirectHandler$ResponseWrapper"),

Review Comment:
   To be clear, do you mean the migration of Javax -> Jakarta in general or for 
the `ProxyRedirectHandler` method in specific?
   I'm bringing this up as `ProxyRedirectHandler` is scoped as private, hence, 
the user shouldn't have access to this class at all. 
   
   I will add a line on `core-migration-guide.md` feel free to comment if that 
is not sufficient. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to