mridulm commented on code in PR #45154:
URL: https://github.com/apache/spark/pull/45154#discussion_r1496821848
##########
project/MimaExcludes.scala:
##########
@@ -79,7 +79,10 @@ object MimaExcludes {
// TODO(SPARK-46878): Invalid Mima report for StringType extension
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.types.StringType.this"),
// SPARK-47011: Remove deprecated
BinaryClassificationMetrics.scoreLabelsWeight
-
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.mllib.evaluation.BinaryClassificationMetrics.scoreLabelsWeight")
+
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.mllib.evaluation.BinaryClassificationMetrics.scoreLabelsWeight"),
+ // SPARK-46938: Javax -> Jakrata namespace change.
+
ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.ui.ProxyRedirectHandler$ResponseWrapper"),
Review Comment:
Very curious why these are showing up in javadoc @dongjoon-hyun - these are
scoped to `private[ui]`, etc.
##########
docs/core-migration-guide.md:
##########
@@ -24,6 +24,8 @@ license: |
## Upgrading from Core 3.5 to 4.0
+- Since Spark 4.0, Spark will migrate its internal reference of servlet API
from `Javax` to `Jakarta`, and it applies to all
Review Comment:
Do we need the "and it applies to all" suffix ?
Why not simply:
```suggestion
- Since Spark 4.0, Spark migrated all its internal reference of servlet API
from `javax` to `jakarta`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
