mihailom-db commented on code in PR #45095: URL: https://github.com/apache/spark/pull/45095#discussion_r1495412865
########## sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala: ########## @@ -1151,6 +1153,21 @@ class QueryExecutionErrorsSuite ) ) } + + test("SPARK-43259: Uses unsupported custom encoder") { + class CustomEncoder extends Encoder[Int] { + override def schema: StructType = StructType(Array.empty[StructField]) + override def clsTag: ClassTag[Int] = ClassTag.Int + } + val e = intercept[SparkRuntimeException] { + encoderFor(new CustomEncoder) Review Comment: I have introduced this change. Just out of curiosity, should we change the error format to pass the type of encoder that was used and then include it in the message? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org