MaxGekk commented on code in PR #45095:
URL: https://github.com/apache/spark/pull/45095#discussion_r1495711840
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -3748,6 +3748,12 @@
},
"sqlState" : "0A000"
},
+ "UNSUPPORTED_ENCODER" : {
+ "message" : [
+ "Found unsupported encoder. Try switching to expression encoder."
Review Comment:
nit:
```suggestion
"Found unsupported encoder. Try switching to an expression encoder."
```
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -3748,6 +3748,12 @@
},
"sqlState" : "0A000"
},
+ "UNSUPPORTED_ENCODER" : {
+ "message" : [
+ "Found unsupported encoder. Try switching to expression encoder."
+ ],
+ "sqlState" : "0A000"
Review Comment:
The category `0A` belongs to:
```
"0A": "feature not supported",
```
see `error-categories.json`. Any reasons to choose this one? How about `46`
or `42`?
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -3748,6 +3748,12 @@
},
"sqlState" : "0A000"
},
+ "UNSUPPORTED_ENCODER" : {
+ "message" : [
+ "Found unsupported encoder. Try switching to expression encoder."
Review Comment:
I think we should help users and point out how to switch to an expression
encoder. At least, let's point out the doc:
https://spark.apache.org/docs/latest/api/java/index.html?org/apache/spark/sql/Encoder.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
