desmondcheongzx commented on code in PR #45131:
URL: https://github.com/apache/spark/pull/45131#discussion_r1498031855


##########
connector/connect/common/src/main/scala/org/apache/spark/sql/connect/common/DataTypeProtoConverter.scala:
##########
@@ -270,6 +271,8 @@ object DataTypeProtoConverter {
               .build())
           .build()
 
+      case VariantType => ProtoDataTypes.VariantType

Review Comment:
   I might be missing something. Is the conversion above---`case 
proto.DataType.KindCase.VARIANT => VariantType`---the conversion in the other 
direction?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to