desmondcheongzx commented on code in PR #45131:
URL: https://github.com/apache/spark/pull/45131#discussion_r1502167567


##########
python/pyspark/sql/types.py:
##########
@@ -1299,6 +1300,12 @@ def fromInternal(self, obj: Tuple) -> "Row":
         return _create_row(self.names, values)
 
 
+class VariantType(AtomicType):

Review Comment:
   (my bad, I thought I'd replied to this last week, but now I see that my 
comment didn't go through)
   
   In this case I was mirroring the definition of the datatype on the scala 
side. We can change both in a future PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to