viirya commented on code in PR #45237:
URL: https://github.com/apache/spark/pull/45237#discussion_r1501680578
##########
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java:
##########
@@ -498,6 +504,8 @@ protected boolean handle(String opt, String value) {
case DRIVER_MEMORY -> conf.put(SparkLauncher.DRIVER_MEMORY, value);
case DRIVER_JAVA_OPTIONS ->
conf.put(SparkLauncher.DRIVER_EXTRA_JAVA_OPTIONS, value);
case DRIVER_LIBRARY_PATH ->
conf.put(SparkLauncher.DRIVER_EXTRA_LIBRARY_PATH, value);
+ case DRIVER_DEFAULT_CLASS_PATH ->
+ conf.put(SparkLauncher.DRIVER_DEFAULT_EXTRA_CLASS_PATH, value);
Review Comment:
Yea, `-c spark.driver.defaultExtraClassPath=""` should be same as
`--driver-default-class-path ""`, so I wonder why we need it especially? And
also what's the case we cannot specify it through `-c
spark.driver.defaultExtraClassPath`?
It's probably okay as we already have `--driver-class-path` so this addition
follows it. Just a question if you know the exact reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
