dongjoon-hyun commented on code in PR #45237:
URL: https://github.com/apache/spark/pull/45237#discussion_r1501680651
##########
launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java:
##########
@@ -271,6 +271,8 @@ Map<String, String> getEffectiveConfig() throws IOException
{
Properties p = loadPropertiesFile();
p.stringPropertyNames().forEach(key ->
effectiveConfig.computeIfAbsent(key, p::getProperty));
+
effectiveConfig.putIfAbsent(SparkLauncher.DRIVER_DEFAULT_EXTRA_CLASS_PATH,
+ SparkLauncher.DRIVER_DEFAULT_EXTRA_CLASS_PATH_VALUE);
Review Comment:
This is required because, when it's loaded from the file,
`p.stringPropertyNames()` doesn't have both
`SparkLauncher.DRIVER_DEFAULT_EXTRA_CLASS_PATH`. So, `.forEach` is not invoked
at all.
```
Properties p = loadPropertiesFile();
p.stringPropertyNames().
```
##########
launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java:
##########
@@ -271,6 +271,8 @@ Map<String, String> getEffectiveConfig() throws IOException
{
Properties p = loadPropertiesFile();
p.stringPropertyNames().forEach(key ->
effectiveConfig.computeIfAbsent(key, p::getProperty));
+
effectiveConfig.putIfAbsent(SparkLauncher.DRIVER_DEFAULT_EXTRA_CLASS_PATH,
+ SparkLauncher.DRIVER_DEFAULT_EXTRA_CLASS_PATH_VALUE);
Review Comment:
This is required because, when it's loaded from the file,
`p.stringPropertyNames()` doesn't have
`SparkLauncher.DRIVER_DEFAULT_EXTRA_CLASS_PATH`. So, `.forEach` is not invoked
at all.
```
Properties p = loadPropertiesFile();
p.stringPropertyNames().
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
