viirya commented on code in PR #45237:
URL: https://github.com/apache/spark/pull/45237#discussion_r1501683488
##########
launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java:
##########
@@ -271,6 +271,8 @@ Map<String, String> getEffectiveConfig() throws IOException
{
Properties p = loadPropertiesFile();
p.stringPropertyNames().forEach(key ->
effectiveConfig.computeIfAbsent(key, p::getProperty));
+
effectiveConfig.putIfAbsent(SparkLauncher.DRIVER_DEFAULT_EXTRA_CLASS_PATH,
+ SparkLauncher.DRIVER_DEFAULT_EXTRA_CLASS_PATH_VALUE);
Review Comment:
Hmm, but I saw you only changed `SparkSubmitCommandBuilder` to explicitly
pick it up? If `SparkLauncher.DRIVER_EXTRA_CLASSPATH` is not set at all, these
other classes won't use `SparkLauncher.DRIVER_DEFAULT_EXTRA_CLASS_PATH` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
