MaxGekk commented on code in PR #45288:
URL: https://github.com/apache/spark/pull/45288#discussion_r1504196644
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -2884,6 +2890,12 @@
],
"sqlState" : "42809"
},
+ "NOT_A_UNRESOLVED_ENCODER" : {
Review Comment:
"not an unresolved encoder" but how about just `NOT_UNRESOLVED_ENCODER`
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -433,6 +433,12 @@
],
"sqlState" : "56000"
},
+ "CLASS_NOT_OVERRIDE_EXPECTED_METHOD" : {
+ "message" : [
+ "<className> must override either <m1> or <m2>."
Review Comment:
Let's assign proper names to parameters:
```suggestion
"<className> must override either <method1> or <method2>."
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala:
##########
@@ -565,7 +565,7 @@ abstract class UnaryExpression extends Expression with
UnaryLike[Expression] {
* of evaluation process, we should override [[eval]].
*/
protected def nullSafeEval(input: Any): Any =
- throw
QueryExecutionErrors.notOverrideExpectedMethodsError("UnaryExpressions",
+ throw
QueryExecutionErrors.notOverrideExpectedMethodsError("UnaryExpression",
Review Comment:
How about to pass the actual class name instead of the parent one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
