dengziming commented on code in PR #45288:
URL: https://github.com/apache/spark/pull/45288#discussion_r1510560284
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala:
##########
@@ -565,7 +565,7 @@ abstract class UnaryExpression extends Expression with
UnaryLike[Expression] {
* of evaluation process, we should override [[eval]].
*/
protected def nullSafeEval(input: Any): Any =
- throw
QueryExecutionErrors.notOverrideExpectedMethodsError("UnaryExpressions",
+ throw
QueryExecutionErrors.notOverrideExpectedMethodsError("UnaryExpression",
Review Comment:
Good suggestion, this can eliminate ambiguity that `UnaryExpression` can
override `eval`, in fact, the actual class override it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
