cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1506046182
##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -341,6 +342,21 @@ public boolean contains(final UTF8String substring) {
return false;
}
+ public boolean contains(final UTF8String substring, int collationId) throws
SparkException {
+ if (CollationFactory.fetchCollation(collationId).isBinaryCollation) {
+ return this.contains(substring);
+ }
+ if (collationId == CollationFactory.LOWERCASE_COLLATION_ID) {
+ return this.toLowerCase().contains(substring.toLowerCase());
+ }
+ // TODO: enable ICU collation support for "contains"
+ Map<String, String> params = new HashMap<>();
+ params.put("functionName",
Thread.currentThread().getStackTrace()[1].getMethodName());
Review Comment:
We should use the SQL function name, which is `contains`. It doesn't matter
what the internal java function name is to end users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
