cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1506054121
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -585,10 +604,23 @@ object ContainsExpressionBuilder extends
StringBinaryPredicateExpressionBuilderB
}
}
-case class Contains(left: Expression, right: Expression) extends
StringPredicate {
- override def compare(l: UTF8String, r: UTF8String): Boolean = l.contains(r)
+case class Contains(left: Expression, right: Expression) extends
StringPredicate
+ with CollationCompatibilityCheck {
+ override def compare(l: UTF8String, r: UTF8String): Boolean = {
+ val collationId = checkCollationIds()
Review Comment:
collation id should be checked only once during analysis, not per row.
Please check `Expression.checkInputDataTypes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
