Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/6430#issuecomment-106594453
  
    Hm, that seems to be so. I'm wondering if there's a better way to simplify 
the cases so we don't have nested ifs. Previously it looks like this:
    ```
    if (needed < target) {
      // cancel
    } else if (need more executors) {
      // add
    }
    ```
    Now we add some new initialization logic in the cancel case. What if we 
express it like:
    ```
    if (initializing && numExecutors != initialExecutors) {
      // resync with cluster manager
    } else if ... // as before
    ```
    It's fairly minor but I think it's simpler to reason about.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to