cloud-fan commented on code in PR #45389:
URL: https://github.com/apache/spark/pull/45389#discussion_r1512856918
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala:
##########
@@ -228,9 +235,10 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
// other choice.
case j @ ExtractEquiJoinKeys(joinType, leftKeys, rightKeys, nonEquiCond,
_, left, right, hint) =>
+ val hashJoinSupport = hashJoinSupported(leftKeys, rightKeys)
def createBroadcastHashJoin(onlyLookingAtHint: Boolean) = {
- val buildSide = getBroadcastBuildSide(
- left, right, joinType, hint, onlyLookingAtHint, conf)
+ val buildSide = Option(hashJoinSupport).filter(identity).flatMap(
Review Comment:
I feel it's clearer to do
```
val buildSide = if (hashJoinSupport) {
getBroadcastBuildSide...
} else {
None
}
```
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala:
##########
@@ -246,8 +254,8 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
}
def createShuffleHashJoin(onlyLookingAtHint: Boolean) = {
- val buildSide = getShuffleHashJoinBuildSide(
- left, right, joinType, hint, onlyLookingAtHint, conf)
+ val buildSide = Option(hashJoinSupport).filter(identity).flatMap(
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
